Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): replace xcpretty with xcbeautify #4645

Merged
merged 3 commits into from
Dec 18, 2024
Merged

chore(ci): replace xcpretty with xcbeautify #4645

merged 3 commits into from
Dec 18, 2024

Conversation

philprime
Copy link
Contributor

@philprime philprime commented Dec 18, 2024 •
edited
Loading

📜 Description

Replaces the Ruby Gem xcpretty with the CLI xcbeautify.

💡 Motivation and Context

💚 How did you test it?

  • Ran commands locally

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

#skip-changelog

@philprime philprime self-assigned this Dec 18, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.616%. Comparing base (b7c9edb) to head (e58f922).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4645       +/-   ##
=============================================
+ Coverage   90.590%   90.616%   +0.026%     
=============================================
  Files          620       620               
  Lines        71075     71072        -3     
  Branches     25311     25902      +591     
=============================================
+ Hits         64387     64403       +16     
+ Misses        6596      6572       -24     
- Partials        92        97        +5

see 22 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c9edb...e58f922. Read the comment docs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.29 ms 1251.14 ms 36.85 ms
Size 22.30 KiB 760.27 KiB 737.96 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ad7cec6 1203.22 ms 1224.74 ms 21.52 ms
b6ba04e 1217.45 ms 1248.92 ms 31.47 ms
1ac58a6 1232.07 ms 1254.69 ms 22.63 ms
7fb7afb 1235.00 ms 1256.81 ms 21.81 ms
26530fe 1233.98 ms 1250.06 ms 16.08 ms
188547e 1241.47 ms 1257.35 ms 15.88 ms
3eb2a52 1241.48 ms 1250.50 ms 9.02 ms
f1b97be 1218.20 ms 1245.84 ms 27.64 ms
6001822 1265.10 ms 1270.40 ms 5.30 ms
b695b61 1221.71 ms 1249.18 ms 27.47 ms

App size

Revision Plain With Sentry Diff
ad7cec6 20.76 KiB 427.32 KiB 406.55 KiB
b6ba04e 20.76 KiB 414.45 KiB 393.69 KiB
1ac58a6 21.58 KiB 626.07 KiB 604.49 KiB
7fb7afb 20.76 KiB 419.69 KiB 398.94 KiB
26530fe 21.58 KiB 714.93 KiB 693.35 KiB
188547e 21.58 KiB 424.34 KiB 402.76 KiB
3eb2a52 20.76 KiB 393.38 KiB 372.62 KiB
f1b97be 21.58 KiB 681.74 KiB 660.16 KiB
6001822 22.85 KiB 410.98 KiB 388.13 KiB
b695b61 21.90 KiB 707.65 KiB 685.75 KiB

Previous results on branch: philprime/replace-xcpretty

Startup times

Revision Plain With Sentry Diff
121a984 1230.20 ms 1246.89 ms 16.69 ms

App size

Revision Plain With Sentry Diff
121a984 22.30 KiB 760.26 KiB 737.96 KiB

@philprime philprime marked this pull request as ready for review December 18, 2024 11:51
brustolin
brustolin approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy and the output does not look that different, so Im happy.

Thanks for this.

@philprime philprime merged commit 0b53d9c into main Dec 18, 2024
70 of 71 checks passed
@philprime philprime deleted the philprime/replace-xcpretty branch December 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brustolin brustolin brustolin approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@armcknight armcknight Awaiting requested review from armcknight armcknight is a code owner

Assignees

@philprime philprime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philprime @brustolin