ref: One class forward declaration per line #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change all class forward declarations to one per line.
philipphofmann
requested review from
brustolin,
armcknight and
philprime
as code owners
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7192d9e | 1221.86 ms | 1248.28 ms | 26.42 ms |
| a176fc4 | 1239.78 ms | 1258.98 ms | 19.20 ms |
| 23ce4a9 | 1275.73 ms | 1278.78 ms | 3.05 ms |
| 154f795 | 1225.53 ms | 1231.04 ms | 5.51 ms |
| 4090908 | 1220.57 ms | 1236.27 ms | 15.69 ms |
| 33c23d3 | 1223.24 ms | 1244.94 ms | 21.69 ms |
| 7fb7afb | 1227.73 ms | 1243.16 ms | 15.43 ms |
| 1e065bc | 1239.69 ms | 1258.18 ms | 18.49 ms |
| 83d84d7 | 1244.92 ms | 1253.34 ms | 8.42 ms |
| 32e64d1 | 1224.45 ms | 1238.94 ms | 14.49 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7192d9e | 20.76 KiB | 431.71 KiB | 410.95 KiB |
| a176fc4 | 22.84 KiB | 403.24 KiB | 380.39 KiB |
| 23ce4a9 | 22.85 KiB | 413.45 KiB | 390.60 KiB |
| 154f795 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
| 4090908 | 21.58 KiB | 669.69 KiB | 648.11 KiB |
| 33c23d3 | 21.58 KiB | 737.53 KiB | 715.95 KiB |
| 7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| 1e065bc | 20.76 KiB | 425.78 KiB | 405.01 KiB |
| 83d84d7 | 22.84 KiB | 402.56 KiB | 379.72 KiB |
| 32e64d1 | 20.76 KiB | 433.18 KiB | 412.42 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4643 +/- ##
=============================================
+ Coverage 90.508% 90.606% +0.097%
=============================================
Files 618 619 +1
Lines 70821 70985 +164
Branches 25102 25879 +777
=============================================
+ Hits 64099 64317 +218
+ Misses 6631 6571 -60
- Partials 91 97 +6 see 56 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
armcknight
approved these changes
Dec 17, 2024
Same for me, that's why I opened this PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all class forward declarations to one per line.
#skip-changelog