feat: Add extra SdkInfo packages #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-unify-sdk-info
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4d6f273 | 1195.63 ms | 1232.22 ms | 36.59 ms |
| 7672856 | 1241.55 ms | 1251.65 ms | 10.09 ms |
| 2405ba5 | 1248.37 ms | 1259.30 ms | 10.93 ms |
| b07998b | 1216.88 ms | 1244.18 ms | 27.31 ms |
| ecd9ecd | 1214.16 ms | 1232.59 ms | 18.43 ms |
| a2af9fa | 1236.29 ms | 1251.67 ms | 15.38 ms |
| 2eb78be | 1225.02 ms | 1235.02 ms | 10.00 ms |
| 369222e | 1232.14 ms | 1258.90 ms | 26.76 ms |
| df2986b | 1227.45 ms | 1244.35 ms | 16.90 ms |
| 50bb751 | 1230.94 ms | 1238.69 ms | 7.75 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4d6f273 | 20.76 KiB | 426.93 KiB | 406.17 KiB |
| 7672856 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
| 2405ba5 | 20.76 KiB | 435.23 KiB | 414.47 KiB |
| b07998b | 22.30 KiB | 749.77 KiB | 727.47 KiB |
| ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
| a2af9fa | 20.76 KiB | 432.88 KiB | 412.11 KiB |
| 2eb78be | 21.58 KiB | 706.97 KiB | 685.39 KiB |
| 369222e | 20.76 KiB | 419.67 KiB | 398.91 KiB |
| df2986b | 22.85 KiB | 406.89 KiB | 384.04 KiB |
| 50bb751 | 21.58 KiB | 417.86 KiB | 396.27 KiB |
Previous results on branch: kw/add-extra-packages
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 34a77c3 | 1238.80 ms | 1257.33 ms | 18.53 ms |
| b7e9d26 | 1213.28 ms | 1251.22 ms | 37.95 ms |
| b5e16d1 | 1234.07 ms | 1256.13 ms | 22.06 ms |
| e8f8eef | 1219.24 ms | 1237.53 ms | 18.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 34a77c3 | 22.31 KiB | 758.40 KiB | 736.10 KiB |
| b7e9d26 | 22.31 KiB | 758.40 KiB | 736.10 KiB |
| b5e16d1 | 22.31 KiB | 758.41 KiB | 736.10 KiB |
| e8f8eef | 22.31 KiB | 758.76 KiB | 736.45 KiB |
krystofwoldrich
requested review from
philipphofmann,
brustolin,
armcknight and
philprime
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4637 +/- ##
=============================================
- Coverage 90.839% 90.564% -0.275%
=============================================
Files 617 619 +2
Lines 71020 70977 -43
Branches 25228 25254 +26
=============================================
- Hits 64514 64280 -234
- Misses 6414 6604 +190
- Partials 92 93 +1
... and 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@philipphofmann I've updated the PR, it's ready for another pass. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR adds ability to add extra packages to SdkInfo.
This PR exposes API for hybrid SDKs to add packages.
This PR replaces chore(internal): Add
packagesset to SentrySdkInfo #4598💚 How did you test it?
tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.