Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo #4632

Merged
merged 1 commit into from
Dec 14, 2024
Merged

fix: typo #4632

merged 1 commit into from
Dec 14, 2024

Conversation

armcknight
Copy link
Member

#skip-changelog

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.875%. Comparing base (fce741e) to head (019b45f).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4632       +/-   ##
=============================================
- Coverage   90.882%   90.875%   -0.008%     
=============================================
  Files          617       617               
  Lines        71032     71030        -2     
  Branches     25332     25322       -10     
=============================================
- Hits         64556     64549        -7     
- Misses        6384      6389        +5     
  Partials        92        92
Files with missing lines Coverage Δ
...tryTests/Networking/SentryHttpTransportTests.swift 99.794% <100.000%> (ø)

... and 10 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce741e...019b45f. Read the comment docs.

philprime
philprime approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

philipphofmann
philipphofmann approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@armcknight armcknight merged commit 419f1d4 into main Dec 14, 2024
42 of 44 checks passed
@armcknight armcknight deleted the armcknight/fix/typo branch December 14, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philprime philprime philprime approved these changes

@brustolin brustolin brustolin approved these changes

@philipphofmann philipphofmann philipphofmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armcknight @philipphofmann @brustolin @philprime