fix(feedback): hide API from public until release #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
requested review from
philipphofmann,
brustolin and
philprime
as code owners
armcknight
force-pushed
the
armcknight/feat(feedback)/api-visibility
branch
from
99b8c9e to
237f9b4
Compare
armcknight
changed the base branch from
main
to
armcknight/feat(feedback)/ui-form-use-user
|
The lint failures are bubbling up from an upstream PR: #4630 (comment) |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dd0557f | 1242.04 ms | 1250.86 ms | 8.82 ms |
| 6ec751f | 1237.88 ms | 1258.47 ms | 20.59 ms |
| 5e65d2b | 1216.08 ms | 1236.08 ms | 20.00 ms |
| b35ccd0 | 1238.67 ms | 1260.35 ms | 21.67 ms |
| 06548c0 | 1225.58 ms | 1244.70 ms | 19.12 ms |
| 4259afd | 1222.12 ms | 1249.74 ms | 27.62 ms |
| ecd9ecd | 1215.77 ms | 1238.70 ms | 22.93 ms |
| 853d797 | 1221.40 ms | 1233.98 ms | 12.58 ms |
| 279351b | 1229.00 ms | 1233.63 ms | 4.63 ms |
| 313b1d9 | 1240.18 ms | 1258.44 ms | 18.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dd0557f | 22.85 KiB | 411.75 KiB | 388.90 KiB |
| 6ec751f | 21.58 KiB | 625.82 KiB | 604.24 KiB |
| 5e65d2b | 21.58 KiB | 616.67 KiB | 595.09 KiB |
| b35ccd0 | 21.58 KiB | 573.13 KiB | 551.55 KiB |
| 06548c0 | 20.76 KiB | 427.35 KiB | 406.59 KiB |
| 4259afd | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
| 853d797 | 21.58 KiB | 630.35 KiB | 608.77 KiB |
| 279351b | 21.58 KiB | 706.53 KiB | 684.95 KiB |
| 313b1d9 | 22.85 KiB | 414.11 KiB | 391.26 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4631 +/- ##
=============================================
+ Coverage 90.848% 90.889% +0.040%
=============================================
Files 617 618 +1
Lines 70930 71069 +139
Branches 25841 25964 +123
=============================================
+ Hits 64439 64594 +155
+ Misses 6394 6379 -15
+ Partials 97 96 -1 see 31 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
approved these changes
Dec 13, 2024
Base automatically changed from
armcknight/feat(feedback)/ui-form-use-user
to
main
December 13, 2024 22:11
…ack)/api-visibility
armcknight
commented
Dec 13, 2024
Samples/iOS-Swift/iOS-Swift.xcodeproj/xcshareddata/xcschemes/iOS-Swift.xcscheme
Outdated
Show resolved
Hide resolved
armcknight
commented
Dec 13, 2024
armcknight
commented
Dec 13, 2024
armcknight
commented
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added to the public header in #4284 but should not have been exposed before the initial rollout of the feature. Let's move them into private headers until we're ready.
#skip-changelog