internal: Remove loading integrations names from event.extra #4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
philipphofmann,
brustolin,
armcknight and
philprime
as code owners
krystofwoldrich
changed the base branch from
main
to
kw/fix-sdk-info-packages
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4627 +/- ##
=============================================
+ Coverage 90.878% 90.911% +0.033%
=============================================
Files 616 617 +1
Lines 70917 71059 +142
Branches 25831 25969 +138
=============================================
+ Hits 64448 64601 +153
+ Misses 6374 6360 -14
- Partials 95 98 +3
... and 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dd0557f | 1246.31 ms | 1258.46 ms | 12.15 ms |
| 06548c0 | 1226.71 ms | 1252.37 ms | 25.66 ms |
| 742d4b6 | 1217.04 ms | 1229.38 ms | 12.33 ms |
| e5a239a | 1231.14 ms | 1245.09 ms | 13.94 ms |
| 45d3ca5 | 1248.27 ms | 1255.48 ms | 7.21 ms |
| d26c417 | 1233.98 ms | 1255.36 ms | 21.38 ms |
| 38b36f5 | 1218.48 ms | 1246.61 ms | 28.13 ms |
| e324230 | 1254.92 ms | 1262.92 ms | 8.00 ms |
| 4886e79 | 1248.43 ms | 1255.04 ms | 6.61 ms |
| 3396be1 | 1242.29 ms | 1254.41 ms | 12.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dd0557f | 22.85 KiB | 411.75 KiB | 388.90 KiB |
| 06548c0 | 20.76 KiB | 427.36 KiB | 406.59 KiB |
| 742d4b6 | 21.58 KiB | 546.19 KiB | 524.61 KiB |
| e5a239a | 21.58 KiB | 713.49 KiB | 691.91 KiB |
| 45d3ca5 | 20.76 KiB | 427.54 KiB | 406.78 KiB |
| d26c417 | 21.58 KiB | 700.28 KiB | 678.70 KiB |
| 38b36f5 | 21.58 KiB | 616.35 KiB | 594.77 KiB |
| e324230 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
| 4886e79 | 22.85 KiB | 412.98 KiB | 390.13 KiB |
| 3396be1 | 22.30 KiB | 730.07 KiB | 707.77 KiB |
brustolin
approved these changes
Dec 13, 2024
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Remove loading integrations names from event.extra ([#4627](https://github.com/getsentry/sentry-cocoa/pull/4627))If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR removes unsafe loading of integrations names from event.extra data bag.
This was used in 0.x.x version of Sentry React Native and used to be a string.
Today integrations are expected to be array.
https://github.com/getsentry/sentry-react-native/blob/v0.14.0/ios/RNSentry.m#L171
https://develop.sentry.dev/sdk/data-model/event-payloads/sdk/
As this is outdated private property removel doesn't have to a breaking change.
💡 Motivation and Context
Removing this will make future refactors easier as sdk info won't depend on event instance.
💚 How did you test it?
unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.