-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump OS versions for unit tests #4542
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4542 +/- ##
=============================================
+ Coverage 90.882% 90.902% +0.019%
=============================================
Files 617 617
Lines 71032 71053 +21
Branches 25332 25949 +617
=============================================
+ Hits 64556 64589 +33
+ Misses 6384 6367 -17
- Partials 92 97 +5
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I believe we should not bump the version from iOS 17 to iOS 18, but instead keep test both versions due to changes in FileIO (#4546). In addition I would propose we also add macOS 15 unit tests to this PR. |
I just noticed the same applies for tvOS 17.5 and 18.1 |
@philipphofmann @armcknight I propose we use this PR to test compatibility with iOS 18, macOS 15 and tvOS 18 by updating the branch to |
We know that file IO instrumentation is broken. I would skip the failing tests for file IO instrumentation on iOS 18, merge this PR, so we run all other tests on iOS 18, and then enable the tests again once we fix the file IO instrumentation. It could also be that the file IO instrumentation won't work anymore on iOS 18, so we can't enable the failing tests anymore. |
As I am about to finish fixing FileIO in #4605, there might not be much of a point in disabling and then re-enabling it, except for having CI running on the introduced OS versions too. But there is actually another test failing with the newer OS versions, we need to look into/disable:
|
It's also fine to disable all failing tests for now and create follow-up issues. Most tests running on iOS 18 is long overdue. |
The broken tests are now skipped, so I believe this can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Testing our SDK in the latest iOS.
#skip-changelog