Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump OS versions for unit tests #4542

Merged
merged 8 commits into from
Dec 13, 2024
Merged

chore: Bump OS versions for unit tests #4542

merged 8 commits into from
Dec 13, 2024

Conversation

brustolin
Copy link
Contributor

Testing our SDK in the latest iOS.

#skip-changelog

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.902%. Comparing base (fce741e) to head (dfae33a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4542       +/-   ##
=============================================
+ Coverage   90.882%   90.902%   +0.019%     
=============================================
  Files          617       617               
  Lines        71032     71053       +21     
  Branches     25332     25949      +617     
=============================================
+ Hits         64556     64589       +33     
+ Misses        6384      6367       -17     
- Partials        92        97        +5     
Files with missing lines Coverage Δ
...ance/IO/SentryFileIOTrackingIntegrationObjCTests.m 96.273% <100.000%> (+0.119%) ⬆️
...ance/IO/SentryFileIOTrackingIntegrationTests.swift 92.990% <100.000%> (+0.416%) ⬆️
...sts/SentryCrash/SentryStacktraceBuilderTests.swift 97.122% <100.000%> (+0.063%) ⬆️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce741e...dfae33a. Read the comment docs.

@philprime
Copy link
Contributor

I believe we should not bump the version from iOS 17 to iOS 18, but instead keep test both versions due to changes in FileIO (#4546).

In addition I would propose we also add macOS 15 unit tests to this PR.

@philprime
Copy link
Contributor

I just noticed the same applies for tvOS 17.5 and 18.1

@philprime philprime changed the title chore: Bump iOS version for unit test chore: Bump OS versions for unit tests Dec 6, 2024
@philprime
Copy link
Contributor

@philipphofmann @armcknight I propose we use this PR to test compatibility with iOS 18, macOS 15 and tvOS 18 by updating the branch to main and merge the PR as soon as all checks pass. When we notice something is broken, like file I/O tracking in #4546, we fix it in other PRs instead. This should lead to multiple commits with clearer intentions.

@philipphofmann
Copy link
Member

We know that file IO instrumentation is broken. I would skip the failing tests for file IO instrumentation on iOS 18, merge this PR, so we run all other tests on iOS 18, and then enable the tests again once we fix the file IO instrumentation. It could also be that the file IO instrumentation won't work anymore on iOS 18, so we can't enable the failing tests anymore.

@philprime
Copy link
Contributor

As I am about to finish fixing FileIO in #4605, there might not be much of a point in disabling and then re-enabling it, except for having CI running on the introduced OS versions too.

But there is actually another test failing with the newer OS versions, we need to look into/disable:

Failing tests:
	-[SentryFileIOTrackingIntegrationObjCTests test_NSFileManagerCreateFile]
	-[SentryFileIOTrackingIntegrationObjCTests test_NSFileManagerCreateFile]
	-[SentryFileIOTrackingIntegrationObjCTests test_NSFileManagerCreateFile]
	-[SentryFileIOTrackingIntegrationObjCTests test_NSFileManagerCreateFile]
	-[SentryFileIOTrackingIntegrationObjCTests test_NSFileManagerCreateFile]
	SentryFileIOTrackingIntegrationTests.test_ReadingURL_Tracking()
	SentryFileIOTrackingIntegrationTests.test_ReadingURLWithOption_Tracking()
	SentryFileIOTrackingIntegrationTests.test_Writing_Tracking()
	SentryFileIOTrackingIntegrationTests.test_WritingWithOption_Tracking()

	SentryStacktraceBuilderTests.testFramesOrder() <---

@philipphofmann
Copy link
Member

It's also fine to disable all failing tests for now and create follow-up issues. Most tests running on iOS 18 is long overdue.

@philprime philprime self-assigned this Dec 12, 2024
@philprime philprime marked this pull request as ready for review December 12, 2024 14:04
@philprime
Copy link
Contributor

The broken tests are now skipped, so I believe this can be merged.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@philprime philprime merged commit 461d953 into main Dec 13, 2024
47 of 48 checks passed
@philprime philprime deleted the chore/bumping-tests branch December 13, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants