fix: Session replay masking not working inside scroll view #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4498 +/- ##
=============================================
+ Coverage 91.439% 91.446% +0.006%
=============================================
Files 616 616
Lines 68794 68812 +18
Branches 24677 24689 +12
=============================================
+ Hits 62905 62926 +21
+ Misses 5796 5794 -2
+ Partials 93 92 -1
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0601b7 | 1221.23 ms | 1231.71 ms | 10.48 ms |
| 704d854 | 1219.82 ms | 1243.69 ms | 23.87 ms |
| 455619d | 1253.08 ms | 1265.06 ms | 11.98 ms |
| b2e7962 | 1234.70 ms | 1241.98 ms | 7.28 ms |
| 5230990 | 1222.86 ms | 1243.59 ms | 20.73 ms |
| 33b2f51 | 1251.24 ms | 1259.18 ms | 7.94 ms |
| df2986b | 1227.45 ms | 1244.35 ms | 16.90 ms |
| 6e342ac | 1216.02 ms | 1232.88 ms | 16.86 ms |
| c45c91c | 1229.49 ms | 1242.94 ms | 13.45 ms |
| 25a5e8b | 1249.18 ms | 1268.42 ms | 19.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0601b7 | 21.58 KiB | 682.12 KiB | 660.54 KiB |
| 704d854 | 21.58 KiB | 615.98 KiB | 594.40 KiB |
| 455619d | 20.76 KiB | 432.87 KiB | 412.11 KiB |
| b2e7962 | 21.58 KiB | 670.39 KiB | 648.81 KiB |
| 5230990 | 21.58 KiB | 682.39 KiB | 660.81 KiB |
| 33b2f51 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
| df2986b | 22.85 KiB | 406.89 KiB | 384.04 KiB |
| 6e342ac | 20.76 KiB | 436.66 KiB | 415.90 KiB |
| c45c91c | 21.58 KiB | 714.30 KiB | 692.72 KiB |
| 25a5e8b | 20.76 KiB | 436.33 KiB | 415.57 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed calculation of scroll view children position for masking
💚 How did you test it?
Unit test and sample
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.