fix: Clarify FramesTracker log message #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change two log messages to state they detected a slow or frozen frame but not to capture them.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3570 +/- ##
=============================================
- Coverage 89.255% 89.202% -0.054%
=============================================
Files 529 529
Lines 57657 57707 +50
Branches 20630 20656 +26
=============================================
+ Hits 51462 51476 +14
- Misses 5287 5317 +30
- Partials 908 914 +6
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e324230 | 1244.43 ms | 1252.98 ms | 8.55 ms |
| d760c3f | 1200.95 ms | 1233.96 ms | 33.00 ms |
| 5d6ce0e | 1227.57 ms | 1241.08 ms | 13.51 ms |
| 7cd187e | 1223.41 ms | 1249.40 ms | 26.00 ms |
| 407ff99 | 1216.63 ms | 1235.50 ms | 18.87 ms |
| dc0db9e | 1246.06 ms | 1260.46 ms | 14.40 ms |
| 881a955 | 1230.98 ms | 1246.22 ms | 15.24 ms |
| 98cca71 | 1210.75 ms | 1240.64 ms | 29.89 ms |
| 9faf217 | 1268.86 ms | 1274.82 ms | 5.96 ms |
| e1eed6b | 1224.63 ms | 1234.84 ms | 10.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e324230 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
| d760c3f | 22.84 KiB | 403.17 KiB | 380.33 KiB |
| 5d6ce0e | 22.85 KiB | 405.38 KiB | 382.53 KiB |
| 7cd187e | 20.76 KiB | 401.66 KiB | 380.89 KiB |
| 407ff99 | 20.76 KiB | 427.87 KiB | 407.10 KiB |
| dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
| 881a955 | 22.85 KiB | 407.63 KiB | 384.79 KiB |
| 98cca71 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
| 9faf217 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| e1eed6b | 20.76 KiB | 432.17 KiB | 411.41 KiB |
brustolin
approved these changes
Jan 29, 2024
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Clarify FramesTracker log message ([#3570](https://github.com/getsentry/sentry-cocoa/pull/3570))If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Change two log messages to state they detected a slow or frozen frame but not to capture them.
💡 Motivation and Context
Came up here getsentry/sentry-cli#1902 (comment).