chore: Test HybridSDK subspec #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
=============================================
- Coverage 88.845% 88.788% -0.058%
=============================================
Files 492 492
Lines 52966 52973 +7
Branches 18967 18973 +6
=============================================
- Hits 47058 47034 -24
- Misses 4950 4978 +28
- Partials 958 961 +3 see 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philipphofmann
approved these changes
May 16, 2023
There was a problem hiding this comment.
Before merging this, please add the error fixed in #3017 back, push the branch, and check if the newly added CI job fails. Then we can merge this. Thanks 👍
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
…y-cocoa into chore/lint-pod-hybridSDK
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8f397a7 | 1251.82 ms | 1268.34 ms | 16.52 ms |
| 326b7eb | 1252.86 ms | 1259.56 ms | 6.70 ms |
| 630ddf4 | 1216.50 ms | 1235.94 ms | 19.44 ms |
| f576153 | 1210.02 ms | 1228.94 ms | 18.92 ms |
| 407ff99 | 1190.89 ms | 1237.18 ms | 46.29 ms |
| 21fd61f | 1226.42 ms | 1247.52 ms | 21.10 ms |
| 904d7fa | 1225.73 ms | 1249.22 ms | 23.49 ms |
| ff09c7e | 1244.86 ms | 1246.68 ms | 1.82 ms |
| 2719ce6 | 1211.75 ms | 1237.16 ms | 25.41 ms |
| 7bc3c0d | 1261.16 ms | 1278.38 ms | 17.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
| 326b7eb | 20.76 KiB | 432.31 KiB | 411.55 KiB |
| 630ddf4 | 20.76 KiB | 432.37 KiB | 411.61 KiB |
| f576153 | 20.76 KiB | 425.77 KiB | 405.01 KiB |
| 407ff99 | 20.76 KiB | 427.86 KiB | 407.10 KiB |
| 21fd61f | 20.76 KiB | 435.50 KiB | 414.74 KiB |
| 904d7fa | 20.76 KiB | 432.87 KiB | 412.11 KiB |
| ff09c7e | 20.76 KiB | 427.77 KiB | 407.00 KiB |
| 2719ce6 | 20.76 KiB | 435.13 KiB | 414.37 KiB |
| 7bc3c0d | 20.76 KiB | 427.36 KiB | 406.59 KiB |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a workflow to test whether
Sentry/HybridSDKpodspec dependency is compiling properly for hybrid SDKs.This was raised because of #3017
closes #3021
#skip-changelog