Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix high percentage of slow frames #1915

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Fix high percentage of slow frames #1915

merged 5 commits into from
Jun 24, 2022

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jun 24, 2022 •
edited
Loading

📜 Description

The SentryFramesTracker didn't handle fps changes from
the CADisplayLink. This is fixed now by calculating the
actual frame rate as pointed out by the docs.

Docs PR getsentry/sentry-docs#5209.

💡 Motivation and Context

Fixes #1881

💚 How did you test it?

Setting preferredframespersecond and running on a real device, real device, unit tests, and UI tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@philipphofmann philipphofmann force-pushed the fix/frames-tracking branch 2 times, most recently from 444a285 to cca4b8f Compare June 24, 2022 09:52
@philipphofmann
Fix high percentage of slow frames
24255b8 
The SentryFramesTracker didn't handle fps changes from
the CADisplayLink. This is fixed now by calculating the
actual frame rate as pointed out by the docs.

Fixes GH-1881, Fixes GH-1165
@philipphofmann philipphofmann marked this pull request as ready for review June 24, 2022 12:47
@philipphofmann philipphofmann changed the title Fix frames tracking Fix slow frames tracking Jun 24, 2022
@philipphofmann philipphofmann changed the title Fix slow frames tracking Fix high percentage of slow frames Jun 24, 2022
@philipphofmann philipphofmann requested a review from brustolin June 24, 2022 13:13
brustolin
brustolin approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is Good!
Ready to merge.

I think we could create an UITest that causes slow and frozen frames, and check whether the new labels in the sample were update. But this could be done in another PR.

@philipphofmann
Copy link
Member Author

philipphofmann commented Jun 24, 2022 •
edited
Loading

I think we could create an UITest that causes slow and frozen frames, and check whether the new labels in the sample were update. But this could be done in another PR.

Yes, I agree. I added an issue #1917

@philipphofmann philipphofmann mentioned this pull request Jun 24, 2022
Closed
@philipphofmann philipphofmann merged commit 0acf9c5 into master Jun 24, 2022
@philipphofmann philipphofmann deleted the fix/frames-tracking branch June 24, 2022 13:39
@philipphofmann philipphofmann mentioned this pull request Jun 27, 2022
Closed
@marandaneto marandaneto mentioned this pull request Jun 28, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brustolin brustolin brustolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

100% slow frame rate for many screens
2 participants
@philipphofmann @brustolin