Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-cocoa
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8.7.2
Choose a base ref
...
head repository: getsentry/sentry-cocoa
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8.7.3
Choose a head ref
  • 12 commits
  • 51 files changed
  • 8 contributors

Commits on May 16, 2023

  1. chore: Move breadcrumb tests to UITest (#3038)

    * Move breadcrumb tests to UITest
    
    * Update InfoForBreadcrumbController.swift
    brustolin authored May 16, 2023
    Configuration menu
    Copy the full SHA
    c6773e5 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'release/8.7.2'

    getsentry-bot committed May 16, 2023
    Configuration menu
    Copy the full SHA
    31208ed View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. chore: Test HybridSDK subspec (#3031)

    Added a workflow to test whether Sentry/HybridSDK podspec dependency is compiling properly for hybrid SDKs
    
    Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
    brustolin and philipphofmann authored May 17, 2023
    Configuration menu
    Copy the full SHA
    fcde045 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Configuration menu
    Copy the full SHA
    736495a View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. chore: Swift usage documentation (#3039)

    Added documentation on how to use swift in the framework.
    
    Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
    brustolin and philipphofmann authored May 19, 2023
    Configuration menu
    Copy the full SHA
    98713e6 View commit details
    Browse the repository at this point in the history
  2. Fix changelog for 8.7.1 (#3046)

    This was a hotfix and not a feature release.
    philipphofmann authored May 19, 2023
    Configuration menu
    Copy the full SHA
    2af280d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. build(deps): bump codecov/codecov-action from 3.1.3 to 3.1.4 (#3053)

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.3 to 3.1.4.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
    - [Commits](codecov/codecov-action@894ff02...eaaf4be)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored May 23, 2023
    Configuration menu
    Copy the full SHA
    4053ee9 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. test: Fix flaky flush integration tests (#3040)

    The test testFlush_CalledMultipleTimes_ImmediatelyReturnsFalse is flaky.
    This PR tries to fix this by not relying on measuring the flush duration
    to identify whether the flush logic exited early. Instead, we now use an
    enum to identify the flush result and assert against it.
    philipphofmann authored May 24, 2023
    Configuration menu
    Copy the full SHA
    2405ba5 View commit details
    Browse the repository at this point in the history
  2. fix: Profiling memory leaks (#3055)

    This fixes most of the memory leaks reported in #2980 
    
    The root of the problem seems to be that `std::thread` does not correctly deallocate parameters that are passed to the newly spawned thread. It's unclear if this is expected behavior or not, but the fix was simple: pass parameters that were being copied (and leaked) by reference.
    
    There's also one more unrelated fix to a crash that I found while debugging the leaks - it turns out `-[NSString stringWithUTF8String:]` can return `nil` for malformed data and we weren't checking for nil.
    
    ---------
    
    Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
    indragiek and getsentry-bot authored May 24, 2023
    Configuration menu
    Copy the full SHA
    98752f3 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. fix: Profiling memory leak in std::thread (#3061)

    * fix: Profiling memory leak in std::thread
    
    std::thread does not free the parameters that are passed to it correctly, fall back to pthread APIs.
    
    * Format code
    
    * Update CHANGELOG.md
    
    * delete params if thread creation fails
    
    ---------
    
    Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
    indragiek and getsentry-bot authored May 25, 2023
    Configuration menu
    Copy the full SHA
    438e21a View commit details
    Browse the repository at this point in the history
  2. fix: use-after-free ASAN warning (#3042)

    Add an argument to debug image providers to specify whether crash info should be collected for the images. Some of these API are declared in public headers, so instead of changing those by adding the parameter, I added new method declarations that the originals call through to with the appropriate parameter value to maintain the previous behavior.
    
    Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
    Co-authored-by: Dhiogo Brustolin <dhiogo.brustolin@sentry.io>
    3 people authored May 25, 2023
    Configuration menu
    Copy the full SHA
    9dbf743 View commit details
    Browse the repository at this point in the history
  3. release: 8.7.3

    getsentry-bot committed May 25, 2023
    Configuration menu
    Copy the full SHA
    9cf7d2e View commit details
    Browse the repository at this point in the history
Loading