Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Detect JavaScript SDKs for clock drift #582

Merged
merged 2 commits into from
May 19, 2020
Merged

fix(server): Detect JavaScript SDKs for clock drift #582

merged 2 commits into from
May 19, 2020

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented May 18, 2020 •
edited
Loading

Turns out that browser SDKs don't send sentry_client in the first place, and we need to apply this logic to all legacy SDKs.

@jan-auer jan-auer requested review from HazAT and a team May 18, 2020 18:24
@jan-auer jan-auer self-assigned this May 18, 2020
untitaker
untitaker approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh

HazAT
HazAT approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data will always be there!

@jan-auer jan-auer merged commit 13890c6 into master May 19, 2020
@jan-auer jan-auer deleted the fix/js-clock-drift-detection branch May 19, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

@HazAT HazAT HazAT approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jan-auer @HazAT @untitaker