feat(memory): Implement shared memory state across Relay #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
changed the title
iambriccardo
commented
Jul 18, 2024
iambriccardo
commented
Jul 18, 2024
jjbayer
reviewed
Jul 18, 2024
loewenheim
reviewed
Jul 19, 2024
iambriccardo
force-pushed
the
riccardo/feat/remove-semaphore
branch
from
b7decf2 to
05b1317
Compare
jjbayer
approved these changes
Jul 19, 2024
relay-server/src/utils/memory.rs
Outdated
| use sysinfo::{MemoryRefreshKind, System}; | ||
|
|
||
| /// Count after which the [`MemoryStat`] data will be refreshed. | ||
| const UPDATE_TIME_THRESHOLD_MS: u64 = 100; |
There was a problem hiding this comment.
Should we make this configurable?
There was a problem hiding this comment.
We could do that, I could put it under the health key.
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Dav1dde
reviewed
Jul 19, 2024
| @@ -220,7 +222,7 @@ impl ServiceState { | |||
| ); | |||
| ProjectCacheService::new( | |||
| config.clone(), | |||
| buffer_guard.clone(), | |||
| MemoryChecker::new(memory_stat.clone(), config.clone()), | |||
There was a problem hiding this comment.
Instead of creating new memory checkers, we could just clone a single one and pass that around and internally create the MemoryStat in the constructor.
There was a problem hiding this comment.
We could also do that yes, we will likely not use MemoryStat in isolation, so it's fair to implement it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new shared memory state
MemoryStatwhich allows polling memory usage from multiple threads.This new mechanism is implemented in place of the old
BufferGuardwhich was statically maxing out the number of possible envelopes that go through Relay.Thanks to the new mechanism, the following code was removed:
BufferGuardand all related codeSemaphoreand all related codeSome tests that tested permits were also removed. We are planning a new implementation of the spooler, in which we will figure out a way to properly test memory limits.
Closes: https://github.com/getsentry/team-ingest/issues/367