feat(spans): disable redis span metrics extraction #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
reviewed
May 16, 2024
@Dav1dde I'm indifferent to this, I could see us needing the db.redis spans in the future, so I'm okay with keeping these spans in the tests, if we re-add them back we'll have something to test against. Also having them there does verify that the metrics are not indeed being extracted. |
|
Sounds good to me, I don't have an issue with keeping them around 👍 |
Dav1dde
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally re-enabled db.redis in order to collect metrics for the cache module. However, since then we decided that the cache module will only look at
cache.*span ops.Therefore we can stop collecting
db.redisspan metrics.