instr(kafka): Improve produce error handling #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the name of the topic in the log message when `producer.send` fails. Report a metric for the number of Kafka messages that fail to enqueue.
mcannizz
changed the title
|
Hi, this is my first time contributing to Relay. I have not yet tested these changes. Can you please advise on what tests I should perform before merging this? Thanks! |
olksdr
reviewed
Mar 28, 2024
relay-kafka/src/producer/mod.rs
Outdated
| @@ -402,7 +402,12 @@ impl Producer { | |||
| relay_log::error!( | |||
| error = &error as &dyn std::error::Error, | |||
| tags.variant = variant, | |||
| "error sending kafka message" | |||
| "error sending kafka message to topic {}", | |||
| topic_name | |||
There was a problem hiding this comment.
Instead of changing the name, please, add the topic name into the tags. E.g.
relay_log::error!(
error = &error as &dyn std::error::Error,
tags.variant = variant,
tags.topic = topic_name,
"error sending kafka message"
jjbayer
approved these changes
Mar 28, 2024
| @@ -402,7 +402,12 @@ impl Producer { | |||
| relay_log::error!( | |||
| error = &error as &dyn std::error::Error, | |||
| tags.variant = variant, | |||
| "error sending kafka message" | |||
| tags.topic = topic_name, | |||
There was a problem hiding this comment.
FWIW, the error was already tagged by variant, which describes what data type was dropped (e.g. "metric").
Dav1dde
reviewed
Mar 28, 2024
| ); | ||
| metric!( | ||
| counter(KafkaCounters::ProducerEnqueueError) += 1, | ||
| topic = topic_name |
There was a problem hiding this comment.
@jjbayer do we wanna also tag this with the variant? I can PR that.
jan-auer
added a commit
that referenced
this pull request
Mar 28, 2024
* master: ref(cardinality): Pipeline Redis script invocations (#3321) ref(normalization): Remove StoreProcessor (#3097) feat(cardinality): Implement name based cardinality limits (#3313) instr(kafka): Tag existing metrics with variant (#3352) instr(kafka): More broker stats (#3349) instr(kafka): Improve produce error handling (#3351) feat(schema): Allow integers as username (#3328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
producer.sendfails.See INC-696 for the motivation behind these changes.
#skip-changelog