instr(kafka): More broker stats #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Mar 28, 2024
| @@ -20,7 +20,7 @@ impl ClientContext for Context { | |||
| relay_statsd::metric!(gauge(KafkaGauges::MessageSize) = statistics.msg_size); | |||
| relay_statsd::metric!(gauge(KafkaGauges::MessageSizeMax) = statistics.msg_size_max); | |||
|
|
|||
| for broker in statistics.brokers.values() { | |||
| for (_, broker) in statistics.brokers { | |||
There was a problem hiding this comment.
It was either this or if let Some(int_latency) = &broker.int_latency {, and I thought this function might as well consume the object.
jan-auer
added a commit
that referenced
this pull request
Mar 28, 2024
* master: ref(cardinality): Pipeline Redis script invocations (#3321) ref(normalization): Remove StoreProcessor (#3097) feat(cardinality): Implement name based cardinality limits (#3313) instr(kafka): Tag existing metrics with variant (#3352) instr(kafka): More broker stats (#3349) instr(kafka): Improve produce error handling (#3351) feat(schema): Allow integers as username (#3328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3315: Also emit
int_latencyandoutbuf_latencymetrics.#skip-changelog