feat(metric-stats): Emit accepted volume #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/feat/metric-stats-volume
branch
from
58982c8 to
e3897dc
Compare
Dav1dde
commented
Mar 19, 2024
jjbayer
reviewed
Mar 19, 2024
jjbayer
approved these changes
Mar 19, 2024
| /// and contain additional metadata, like the cardinality of a metric. | ||
| #[derive(Clone, Debug)] | ||
| pub struct MetricStats { | ||
| config: Arc<Config>, |
There was a problem hiding this comment.
nit: Is config only used to check processing_enabled? If so, we could give MetricStats a noop variant instead, something like
enum MetricStats {
Disabled,
Enabled {
global_config: GlobalConfigHandle,
aggregator: Addr<Aggregator>,
}
}There was a problem hiding this comment.
That makes dealing with self awkward, since I have to pattern match it in every method.
Dav1dde
force-pushed
the
dav1d/feat/metric-stats-volume
branch
from
29b3e41 to
328e79c
Compare
Dav1dde
force-pushed
the
dav1d/feat/metric-stats-volume
branch
from
328e79c to
821364d
Compare
Dav1dde
force-pushed
the
dav1d/feat/metric-stats-volume
branch
from
821364d to
131093a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emits positive metric stats for the custom metrics namespace after submission to Kafka.
Only implements the happy path for metric stats and only volume.