Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): Scrub integer file extensions #2856

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Dec 15, 2023

We've seen resource span descriptions like http://domain.com/*.123 which cause high cardinality in the extension.

#skip-changelog

@jjbayer jjbayer marked this pull request as ready for review December 15, 2023 14:29
@jjbayer jjbayer requested a review from a team as a code owner December 15, 2023 14:29
@jjbayer jjbayer enabled auto-merge (squash) December 15, 2023 14:30
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just have a whitelist of extensions instead?

@jjbayer jjbayer merged commit 901fb84 into master Dec 15, 2023
21 checks passed
@jjbayer jjbayer deleted the fix/spans-resource-img-ext branch December 15, 2023 14:41
@jjbayer
Copy link
Member Author

jjbayer commented Dec 15, 2023

Maybe we should just have a whitelist of extensions instead?

@Dav1dde That's a good point. @DominikB2014 would the list of supported images be short enough to enumerate?

@DominikB2014
Copy link
Contributor

Maybe we should just have a whitelist of extensions instead?

@Dav1dde That's a good point. @DominikB2014 would the list of supported images be short enough to enumerate?

We do have a list of extensions that we look for in the FE

https://github.com/getsentry/sentry/blob/master/static/app/views/performance/browser/resources/shared/constants.ts

This mostly lines up with

https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types

But I'm not sure if this includes all types tho. Are we able to query for all extensions that we have seen to be sure?

jan-auer added a commit that referenced this pull request Dec 19, 2023
* master: (35 commits)
  fix(spans): Parse quotes in MySQL (#2846)
  ref(cardinality): Use a Lua script and in-memory cache for the cardinality limiter (#2849)
  fix(spans): Detect hex with fallback scrubber (#2868)
  release: 23.12.0
  Revert "ci: Update upload-artifact and download-artifact actions" (#2866)
  Revert "build: Update axum and http" (#2863)
  feat(spans): Allow resource.img spans (#2855)
  build: Update axum and http (#2844)
  fix(build): Add additional dependencies to the release build (#2858)
  ci: Update upload-artifact and download-artifact actions (#2861)
  feat(spans): Parse timestamps from strings (#2857)
  fix(spans): Scrub integer file extensions (#2856)
  feat(spans): Remove unused transaction tag from resource metrics (#2853)
  ref(cardinality): Recover buckets on cardinality limiter failure (#2852)
  feat(server): Org rate limit per metric bucket (#2836)
  ref(spans): List metric tags explicitly (#2834)
  feat(spans): Resource response sizes as measurements (#2845)
  feat(crons): Add thresholds to monitor config payload (#2842)
  feat(spans): Allow ingestion of metrics summary on spans (#2823)
  ref(crons): Add documentation to CheckInMessageType (#2840)
  ...
@jjbayer
Copy link
Member Author

jjbayer commented Jan 2, 2024

But I'm not sure if this includes all types tho. Are we able to query for all extensions that we have seen to be sure?

@DominikB2014 I ran a query and posted the results here, let me know which of those you would like to add to the allowlist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants