Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(py): Rename sampling to rule condition #2720

Merged
merged 2 commits into from
Nov 14, 2023
Merged

ref(py): Rename sampling to rule condition #2720

merged 2 commits into from
Nov 14, 2023

Conversation

jan-auer
Copy link
Member

Renames validate_sampling_condition to validate_rule_condition in the C-ABI
and python bindings to make it clear that this function validates all kinds of
rule conditions.

@jan-auer jan-auer requested a review from a team November 14, 2023 10:20
olksdr
olksdr approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jan-auer jan-auer enabled auto-merge (squash) November 14, 2023 10:25
@jan-auer jan-auer merged commit a6e3c40 into master Nov 14, 2023
20 checks passed
@jan-auer jan-auer deleted the ref/validate-rule-condition branch November 14, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olksdr olksdr olksdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @olksdr