Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Dockerfile #23

Merged
merged 1 commit into from
May 15, 2018
Merged

feat: Add Dockerfile #23

merged 1 commit into from
May 15, 2018

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented May 15, 2018

Automatic build will be added after this PR is merged.

@tonyo tonyo requested a review from mitsuhiko as a code owner May 15, 2018 15:14
@tonyo tonyo requested review from jan-auer and removed request for mitsuhiko May 15, 2018 15:15
jan-auer
jan-auer reviewed May 15, 2018
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering if we could just reuse a binary built in the respective build job and just do a CP (i.e. only the second stage).

@tonyo
Copy link
Contributor Author

tonyo commented May 15, 2018

@jan-auer true, it would be useful to have, let's leave it for later, though.

jan-auer
jan-auer approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, let's keep this solution for now and revise when we fix up Zeus.

@tonyo tonyo merged commit 429de42 into master May 15, 2018
@tonyo tonyo deleted the feat/add-dockerfile branch May 15, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyo @mitsuhiko @jan-auer