instr(metrics): Add values to invalid metric errors #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
approved these changes
Jun 12, 2023
| @@ -874,19 +874,19 @@ impl From<AggregateMetricsErrorKind> for AggregateMetricsError { | |||
| enum AggregateMetricsErrorKind { | |||
| /// A metric bucket had invalid characters in the metric name. | |||
| #[error("found invalid characters")] | |||
| InvalidCharacters, | |||
| InvalidCharacters(String), | |||
There was a problem hiding this comment.
in each of this cases you add, you might want to update also the macro like #[error("found invalid characters: ({0})")] to actually print the error with the wrong value.
What do you think?
There was a problem hiding this comment.
I was wondering how the new error message would be printed.
There was a problem hiding this comment.
Good one, that's what I actually wanted.
iker-barriocanal
approved these changes
Jun 12, 2023
jan-auer
added a commit
that referenced
this pull request
Jun 14, 2023
* master: (32 commits) feat(txname): Mark all URL transactions as sanitized (#2210) fix(profiles): Enforce profile quotas on metrics buckets (#2212) revert(spans): Move span metrics back to transactions namespace (#2206) instr(metrics): Add values to invalid metric errors (#2201) ref(spans): Move span metrics to spans namespace (#2205) chore(protocol): Add missing py/changelog entry for lock property (#2203) build(py): Move pytest.ini to tests directory (#2204) ref: Use serde collect_str to avoid allocations (#2149) chore(gocd): Auto approve deploy relay-pop on check success (#2200) test(document-pii): Fix flaky test (#2198) feat(spans): Extract transaction `user` into span's databag (#2197) feat(spans): Extract `release` tag from the transaction to the span (#2189) ref(metrics-extraction): Split span and transaction metric extraction (#2191) ref(crons): Support GET in the check-in endpoint (#2192) ref(spans): Introduce opinionated casing in span metrics (#2193) chore(py): Bump `requests` lib version (#2194) doc: document pii fields (#1972) feat: Added cron specific endpoint (#2153) feat(profiling): Extract app identifier from app context (#2172) feat(ci): Add CI-check for pop-deploys (#2184) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fail to add a metric to the aggregator, log the value that caused the problem.
This should make it easier to review related error logs.
#skip-changelog