Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(general): Do not require breadcrumb timestamps #144

Merged
merged 1 commit into from
Jan 17, 2019
Merged

ref(general): Do not require breadcrumb timestamps #144

merged 1 commit into from
Jan 17, 2019

Conversation

jan-auer
Copy link
Member

The UI will not break with this and render the current time instead. We should submit a patch that renders nothing instead.

@jan-auer jan-auer self-assigned this Jan 16, 2019
@jan-auer jan-auer requested a review from untitaker January 16, 2019 16:06
untitaker
untitaker approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's block this on the UI update though

@jan-auer
Copy link
Member Author

Ref getsentry/sentry#11567

@jan-auer jan-auer merged commit 7ce46fc into master Jan 17, 2019
@jan-auer jan-auer deleted the ref/breadcrumb-timestamp-optional branch January 17, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @untitaker