feat: Extract normalized dist as metric [INGEST-335] #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Dec 15, 2021
| if erase { | ||
| *dist = None; | ||
| } | ||
| } |
There was a problem hiding this comment.
Added the erase flag here because I cannot set dist while checking its contents. I don't like it though - any suggestions welcome.
untitaker
approved these changes
Dec 16, 2021
Co-authored-by: Markus Unterwaditzer <markus-honeypot@unterwaditzer.net>
untitaker
reviewed
Dec 16, 2021
relay-general/src/store/normalize.rs
Outdated
|
|
||
| #[test] | ||
| fn test_normalize_dist_empty() { | ||
| let mut dist = Option::Some("".to_owned()); |
There was a problem hiding this comment.
my prev code suggestion goes for all testcases here fwiw
There was a problem hiding this comment.
Right, I did the lazy thing and pressed "Commit suggestion". Will change other instances as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply normalization to
event.distand add as tag to every transaction metric.There is no further normalization in sentry python code as far as I can see: The dist is accepted in event_manager unaltered:
https://github.com/getsentry/sentry/blob/44d7aa211d67b64884230d833f6e485a96357ad6/src/sentry/event_manager.py#L674