This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
feat(crons): Update SDK docs for empty check-ins #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
davidenwang
approved these changes
May 30, 2023
cleptric
reviewed
May 30, 2023
cleptric
reviewed
May 30, 2023
| This may be provided as a empty UUID (128 bit zero value) to indicate to | ||
| Sentry that the checkin should update the previous check-in that is not in | ||
| the terminal state. If the most recent check-in is already in a terminal | ||
| state a new one will be created instead. |
There was a problem hiding this comment.
It might be worth clarifying what terminal state means.
There was a problem hiding this comment.
yeah reverse the logic so it should "update the most recent check-in in an in progress state. If the most recent check-in is not in progress..."
evanpurkhiser
added a commit
to getsentry/sentry
that referenced
this pull request
Jun 2, 2023
This is to support getsentry/relay#2153 Provdes a means to creating check-ins without giving a check_in_id in the consumer payload. Documentation for this is here getsentry/develop#950 Fixes: #49664
evanpurkhiser
added a commit
to getsentry/sentry
that referenced
this pull request
Jun 2, 2023
This is to support getsentry/relay#2153 Provdes a means to creating check-ins without giving a check_in_id in the consumer payload. Documentation for this is here getsentry/develop#950 Fixes: #49664
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-update-sdk-docs-for-empty-check-ins
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See getsentry/sentry#49664