Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trying to update sentry cli #178

Merged
merged 32 commits into from
Dec 6, 2023
Merged

feat: trying to update sentry cli #178

merged 32 commits into from
Dec 6, 2023

Conversation

scefali
Copy link
Contributor

@scefali scefali commented Nov 29, 2023

This PR updates the CLI to the latest version of 2.23.0

@scefali scefali force-pushed the feat/upgrade-cli-version branch from 2b85191 to 655c647 Compare December 4, 2023 19:22
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
@scefali scefali marked this pull request as ready for review December 6, 2023 21:04
RUN mv /action-release/node_modules/@sentry/cli/sentry-cli /action-release/sentry-cli
RUN chmod +x /action-release/sentry-cli
# Workaround for this issue: https://github.com/libgit2/libgit2/issues/6663
RUN printf '[safe]\n directory = *\n' > /etc/gitconfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantically only the second line is a workaround -- the first line is "correct" for git here

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scefali scefali merged commit 3b41b36 into master Dec 6, 2023
5 checks passed
@scefali scefali deleted the feat/upgrade-cli-version branch December 6, 2023 22:30
scefali pushed a commit that referenced this pull request Dec 7, 2023
scefali pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants