ci: End to end testing #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For PRs, the CI will create releases under the action-release-prs project while master will create them for the action-release project. We use different projects since the Release feature does not handle different environments as a way to separate commits. Alternatively, we could have postfixed a different string per PR and use the same project.
armenzg
commented
Apr 27, 2023
| # instead of action-release-prs | ||
| # For other branches: https://sentry-ecosystem.sentry.io/releases/?project=4505075304693760 | ||
| # For master branch: https://sentry-ecosystem.sentry.io/releases/?project=6576594 | ||
| SENTRY_PROJECT: ${{ vars.SENTRY_PROJECT }} |
There was a problem hiding this comment.
You can see in the following screenshot how I pick the right project name based on the branch used:
| @@ -11,6 +19,8 @@ jobs: | |||
| steps: | |||
| - name: Checkout repo | |||
| uses: actions/checkout@v3 | |||
| with: | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
This is explained in the troubleshoot section.
| ref: ${{ github.event.pull_request.head.sha || github.sha }} | ||
|
|
||
| # This allows executing the action's code in the next step rather than a specific tag | ||
| - uses: './.github/actions/use-local-dockerfile' |
There was a problem hiding this comment.
This is basically an sed command to tell the action to use the Dockerfile found in the checkout.
diff --git a/action.yml b/action.yml
index 89bbe57..4095cbe 100644
--- a/action.yml
+++ b/action.yml
@@ -47,7 +47,7 @@ inputs:
runs:
using: 'docker'
# If you change this, update the use-local-dockerfile action
- image: 'docker://ghcr.io/getsentry/action-release-image:latest'
+ image: 'Dockerfile'
branding:
icon: 'triangle'
color: 'purple'
armenzg
changed the title
kamilogorek
reviewed
Apr 28, 2023
kamilogorek
reviewed
Apr 28, 2023
mattgauntseo-sentry
approved these changes
Apr 28, 2023
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PRs, the CI will create releases under the action-release-prs project while master will create them for the action-release project.
We use different projects since the Release feature does not handle different environments as a way to separate commits. Alternatively, we could have postfixed a different string per PR and use the same project.
This PR also enable us to test real action-release execution (read: end to end testing).