Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch: create_compute_environment() now validates instanceRole and minvCpu #6470

Conversation

bblommers
Copy link
Collaborator

Fixes #6463

@bblommers bblommers added this to the 4.1.13 milestone Jun 30, 2023
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #6470 (62ee03d) into master (22774e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #6470    +/-   ##
========================================
  Coverage   96.17%   96.17%            
========================================
  Files         800      800            
  Lines       78355    78501   +146     
========================================
+ Hits        75357    75502   +145     
- Misses       2998     2999     +1     
Flag Coverage Δ
servertests 36.88% <0.00%> (-0.04%) ⬇️
unittests 96.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/batch/models.py 90.81% <100.00%> (+0.04%) ⬆️

... and 7 files with indirect coverage changes

@bblommers bblommers merged commit 8e35eed into getmoto:master Jul 1, 2023
@bblommers bblommers deleted the batch/create_compute_environment_improve_validation branch July 1, 2023 10:33
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

This is now part of moto >= 4.1.13.dev17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch.create_compute_environment() call fails against moto server
1 participant