avoid generating internal frames #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
commented
Aug 22, 2024
| @@ -1,4 +1,4 @@ | |||
| package kyo.examples.ledger | |||
| package examples.ledger | |||
There was a problem hiding this comment.
Moves the examples out of the kyo package so they can generate frames.
fwbrasil
commented
Aug 22, 2024
| private def frameImpl(using Quotes): Expr[String] = | ||
| private[kyo] inline def internal: Frame = ${ frameImpl(true) } | ||
|
|
||
| private val allowKyoFileSuffixes = Set("Test.scala", "Spec.scala", "Bench.scala") |
There was a problem hiding this comment.
The macro has this allow list for tests and benchmarks.
fwbrasil
force-pushed
the
avoid-internal-frames
branch
from
d8746c5 to
15bfd94
Compare
fwbrasil
force-pushed
the
avoid-internal-frames
branch
from
15bfd94 to
e7fffd5
Compare
fwbrasil
commented
Aug 22, 2024
| @@ -17,6 +17,7 @@ given zioSchema[R, A: Flat, S](using ev: Schema[R, A], ev2: (A < S) <:< (A < (Ab | |||
| ev.toType_(isInput, isSubscription) | |||
|
|
|||
| override def resolve(value: A < S): Step[R] = | |||
| given Frame = Frame.internal | |||
There was a problem hiding this comment.
There are some situations where an internal frame is necessary. Frame.internal is a private[kyo] API that allows generating a frame within the kyo package.
hearnadam
approved these changes
Aug 22, 2024
hearnadam
reviewed
Aug 22, 2024
| s"""Frame cannot be derived within the kyo package: ${sym.owner.fullName} | ||
| | | ||
| |To resolve this issue: | ||
| |1. Propagate the Frame from user code using an implicit parameter. |
There was a problem hiding this comment.
implicit?? What is this, Scala 2.13?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Framemacro fail to compile in case the frame is in thekyopackage and fixes the methods in the codebase that were missing the implicit.