Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in classes and outerclasses and added outerclasses to column and section fields. New div block for field.outerclasses. New headgin_classes tag for h1 tag #2424

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fixed typo in classes and outerclasses and added outerclasses to column and section fields. New div block for field.outerclasses. New headgin_classes tag for h1 tag #2424

wants to merge 6 commits into from
+22 −13

Conversation

pmoreno-rodriguez
Copy link
Contributor

No description provided.

@pmoreno-rodriguez
Copy link
Contributor Author

Hi @rhukster

Regarding this pull request, I have modified the following to make it consistent across all Grav theme templates in the Admin plugin:

Fixed field_classes to field.classes for some field types.
Separated classes from outerclasses, adding a div block for the latter.
Added field.heading_classes to differentiate classes in the h1 tag from classes used in other blocks
I am still reviewing the use of classes in the rest of the Admin plugin templates. If you see these changes well, I will add the necessary help in Grav Learn Docs for the new attributes

@pmoreno-rodriguez pmoreno-rodriguez changed the title Fixed typo in classes and outerclasses and added outerclasses to column and section fields Fixed typo in classes and outerclasses and added outerclasses to column and section fields. New div block for field.outerclasses. New headgin_classes tag for h1 tag Dec 23, 2024
@pmoreno-rodriguez
Copy link
Contributor Author

pmoreno-rodriguez commented Dec 23, 2024 •
edited
Loading

Ok. @rhukster

I think I've made too many commits on the same files, in two different pull requests, and maybe I should organize my Admin plugin repository, and make a single pull request with all the files I propose to modify. That way it would be clearer.

Right now, even I'm getting confused.

Do you think I should close pull requests #2432 and #2424 to unify all the changes in a single pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pmoreno-rodriguez