Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media Twig variable in templates #356

Closed
wants to merge 4 commits into from
Closed

media Twig variable in templates #356

wants to merge 4 commits into from

Conversation

hwmaier
Copy link
Contributor

@hwmaier hwmaier commented Oct 14, 2015

Page content can access media files through page.media but also through media Twig variables.

However for templates the media Twig variable is missing while the header shortcut does exist here as well.

To be consistent I suggest to make media available in templates as well.

@hwmaier
Copy link
Contributor Author

hwmaier commented Oct 14, 2015

Sorry, my local repo was't properly synced with head and I messed up the pull request and included a previous PR (16ac497, which has already been accepted and merged) by accident. I will be more careful next time.

Only the commit c4c95cb should be applied.

rhukster added a commit that referenced this pull request Oct 14, 2015
@rhukster
Added for consistency #356
52fcf7c
@rhukster
Copy link
Member

I just added it manually as this PR was a bit confusing :)

@rhukster rhukster closed this Oct 14, 2015
@hwmaier
Copy link
Contributor Author

hwmaier commented Oct 14, 2015

I know. Sorry for the trouble, I have to learn how to rebase my forked repo...

@hwmaier hwmaier deleted the feature/media-for-templates branch October 25, 2015 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwmaier @rhukster