Gregwar/* packages point at a development branch #3289
Comments
|
@jackthomasatl Thank you! |
|
@jackthomasatl Unfortunately that is not true. https://github.com/Gregwar/Cache/tags hasn't been released with PHP 8 fix, which breaks the Image component with Grav. So no, we cannot go back using the official release just yet. I recommend keeping a lot of noise in Gregwar/Cache#33 |
|
That branch does not exist on gregwar |
|
Composer is broken past grav 1.7-RC17 |
|
I have no idea how you say that composer is broken. I just ran: And it works just fine. |
|
If you run composer update on that same project, It breaks. The reason create-project / install works is that your composer.lock is pointed at specific commits on gregwar, When you run composer update it tries to pull the branch php8 on gregwar, Which does not exist. We're using grav as a dependency, not as the base project. |
|
No, it doesn't. I just ran composer update. If you look at the |
|
If you put the following composer.json in a directory then run composer update |
|
What's going on here, is that under getgrav/grav you have repositories specified in composer.json This only works for the root of the project, any other project using grav as a dependency is broken. You're pointing at a branch on gregwar/image and gregwar/cache that DOES NOT EXIST. |
|
You need to add those. Basically it's the only way to get Grav to work in PHP8. |
|
I'm behind a corporate network with firewalls and what not, where we don't have direct internet access. That sort of thing won't work. Our access to packagist is via artifactory cache server. The solution I'm using is to point dev-php8 back to the latest version of those libraries. {
"require": {
"composer/composer": "^1.10",
"composer/ca-bundle": "^1.0",
"gregwar/image": "2.1.0 as dev-php8",
"gregwar/cache": "1.0.12 as dev-php8",
"getgrav/grav": "~1.7",
"oomphinc/composer-installers-extender": "^2.0"
},
"extra": {
"installer-types": [
"project"
]
}
}I think going outside of packagist is hacky. If you're going to fork gregwar, do it properly and publish getgrav/image to packagist and just fork the library until its in a state where its usable again. |
|
I have the same exact problem being behind a corporate firewall. It would solve the problem if the libraries listed in the repositories went through Packagist as @jackthomasatl has suggested. |
|
Can you guys please fix this? Your package is broken if downloaded via normal php channels. Adding in your out of band repository is not an acceptable solution. If you want to fork the library, that's fine. But go all the way and fork it. The half way, out of band solution does not work. Please fix this. |
|
We're not interested in forking this package, we just need to use our temporary version with our fixes until the official package maintainer releases a version with the appropriate fixes. We are doing this the 'proper' composer way by referencing our own repo. It 100% works with composer. For example: So update works fine. |
|
for good measure i deleted the entire If this didn't work our build process would fail. That is used to build Grav on github itself. |
|
Alright people, I hear what you are saying and I get your point. I will work on making the packages available through the official channel until Cheers. |
|
This is now sorted and next version will no longer use any VCS. I did not really appreciate multiple comments in the span of few minutes just to ping the team directly. Be cool and do it once in the main description. Also don't have colleagues piling up echoing the same issue, it's not going to change our perspective of how minor this issue was. Of course you got what you wanted and at the end of the day, we all just want the project to be better and cover all environments, including your very specific one. Please next time you open up an issue, be more respectful of this project, and us. Cheers, |
Gregwar/* dev-php8 branches have been merged, Downloading grav via packagist has been broken since Feb 17.
The text was updated successfully, but these errors were encountered: