Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI selfupgrade to RC20 Claims Success But Does Not Update #3116

Closed
thekenshow opened this issue Dec 28, 2020 · 6 comments
Closed

CLI selfupgrade to RC20 Claims Success But Does Not Update #3116

thekenshow opened this issue Dec 28, 2020 · 6 comments
Assignees
@mahagr
Labels
1.7 bug fixed

Comments

@thekenshow
Copy link
Contributor

Used bin/gpm selfupgrade successfully on my local dev system (PHP 7.3.20). When I tried that on production (PHP 7.3.25), I got the success message below:

CLI_selfupgrade-result

But bin/grav -V returns "Grav CLI Application 1.7.0-rc.17"

Ran the update in Admin and it succeeded and CLI now throws error "PHP version ">= 7.3.6". You are running 7.2.24-0ubuntu0.18.04.7".

So my CLI version on production was the issue - a check and warning message before update/upgrade would be helpful.
@rhukster
Copy link
Member

Can you try this again with the latest 1.7.0 final release? I think it must be a caching issue, can you try clearing cache afterward also?

@mahagr
Copy link
Member

mahagr commented Jan 20, 2021 •
edited
Loading

Grav 1.7.0-rc.17 was the last version supporting PHP 7.2. To me, it looks like the installation fails but CLI fails to report the error.

You need to upgrade the PHP version you're using in CLI.

@mahagr mahagr self-assigned this Jan 20, 2021
mahagr added a commit that referenced this issue Jan 20, 2021
@mahagr
Fixed bin/gpm selfupgrade failing to report failed Grav update [#3116]
6992d52
@mahagr mahagr added the fixed label Jan 20, 2021
@mahagr
Copy link
Member

mahagr commented Jan 20, 2021

OK, this was an issue with installation error detection when using the command (it was only detecting unzip issues).

Unfortunately, this will still be an issue when upgrading from older versions, but at least it is fixed from Grav 1.7.1 onwards.

@thekenshow
Copy link
Contributor Author

Thanks, I'll test this on my next update.

@mahagr
Copy link
Member

mahagr commented Jan 20, 2021 •
edited
Loading

I don't think you can test this because of the issue is in Grav 1.6 and you need to get your CLI to use PHP 7.3/7.4 to update in the first place.

@thekenshow
Copy link
Contributor Author

I have other sites hosted on this server, and I have updated my CLI PHP version.

@mahagr mahagr closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahagr mahagr

Labels
1.7 bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mahagr @thekenshow @rhukster