Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grav 1.7 RC.5: FlexObject::triggerEvent() does not emit events #2816

Closed
pamtbaau opened this issue Feb 6, 2020 · 3 comments
Closed

Grav 1.7 RC.5: FlexObject::triggerEvent() does not emit events #2816

pamtbaau opened this issue Feb 6, 2020 · 3 comments
Assignees
@mahagr
Labels
1.7 bug fixed

Comments

@pamtbaau
Copy link
Contributor

pamtbaau commented Feb 6, 2020 

// FlexObject

public function triggerEvent($name)
{
    return $this;
}
@mahagr
Copy link
Member

mahagr commented Feb 7, 2020

Yup, I'm just using it in child classes. I had an idea to implement it in the base class but looks like I forgot.

@mahagr mahagr self-assigned this Feb 7, 2020
mahagr added a commit that referenced this issue Feb 10, 2020
@mahagr
Fixed FlexObject::triggerEvent() does not emit events [#2816]
234abb3
@mahagr mahagr added the fixed label Feb 10, 2020
@mahagr
Copy link
Member

mahagr commented Feb 10, 2020

Note that I added a new set of classes which should be used instead of the Framework ones (unless you make your own).

@mahagr mahagr closed this as completed Feb 12, 2020
@pamtbaau
Copy link
Contributor Author

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahagr mahagr

Labels
1.7 bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahagr @pamtbaau