PHP 7.4 fix for Pages::buildSort()

getgrav · Dec 2, 2019 · 238ba9b · 238ba9b
1 parent 1d966a0
commit 238ba9b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 ## mm/dd/2019
 
 1. [](#bugfix)
+    * PHP 7.4 fix in `Pages::buildSort()`
     * Fixed fatal error when `$page->id()` is null [#2731](https://github.com/getgrav/grav/pull/2731)
     * Fixed cache conflicts on pages with no set id
 

diff --git a/system/src/Grav/Common/Page/Pages.php b/system/src/Grav/Common/Page/Pages.php
@@ -1306,7 +1306,7 @@ protected function buildSort($path, array $pages, $order_by = 'default', $manual
                 case 'folder':
                     $list[$key] = $child->folder();
                     break;
-                case (is_string($header_query[0])):
+                case (isset($header_query[0]) && is_string($header_query[0])):
                     $child_header = new Header((array)$child->header());
                     $header_value = $child_header->get($header_query[0]);
                     if (is_array($header_value)) {