-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrollbars would always be visible in the VotesModal
component
#1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before with overflow-scroll there where always two scrollbars, now it will change depending on the content of the container
Thank you :) |
Tehem
added a commit
to Tehem/fider
that referenced
this pull request
Nov 12, 2024
* Fix typo in `Welcome Message` section (getfider#1111) * fix: make linter happy again * chore: update playwright to fix build * more subdomain restrictions * feature: send welcome email on signup * fix: unencrypted smtp login * send welcome email * skip email on self hosted * update readme * typo * fix: postgres encoding error doing searches * fix: use hostname for powered by link * update to go 1.19 and node 18.x (getfider#1118) * fix: disallow external url during oauth login * fix: use non-breaking spaces for assertions * dont write to body when method is head * Scrollbars would always be visible in the `VotesModal` component (getfider#1134) * enhancement: add overflow-auto utility class * fix: auto remove scrollbars if there not necessary Before with overflow-scroll there where always two scrollbars, now it will change depending on the content of the container * fix error on cname lookup * use jwt to prevent redirect_uri changes * npm ci --maxsockets 1 * better validation for redirect * Update go to 1.22 * Node 18 -> 22 * Fix build script. * csrf middleware * Added migration to create missing posts.user_id index * Show email on the member listing * Only include email when listing the members. * lint fix. * fix: added an empty view query params checker and setting it to 'all' * Update golint-ci * More time for lint-server * feat: migrated form/Select class component to functional component (based this off of the form/Input component), changed the version in go.mod to 1.22 * Update FUNDING.yml Changed funding options * fix: added back 1.22.0 to go.mod * feat: add Arabic locales * Also publish on tag pushes. * chore(deps): bump ws Bumps and [ws](https://github.com/websockets/ws). These dependencies needed to be updated together. Updates `ws` from 8.4.2 to 8.18.0 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.4.2...8.18.0) Updates `ws` from 7.5.7 to 8.18.0 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.4.2...8.18.0) --- updated-dependencies: - dependency-name: ws dependency-type: indirect - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps-dev): bump @babel/traverse from 7.17.10 to 7.25.4 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.17.10 to 7.25.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.25.4/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Another way to trigger on tag/releases. * Wasn't picking up the tag name properly * Trigger a build when we push to stable too. * chore(deps-dev): bump webpack from 5.72.0 to 5.94.0 Bumps [webpack](https://github.com/webpack/webpack) from 5.72.0 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.72.0...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * Userlist integration added - new signup will create company and user in userlist.com * Updating a user feeds into userlist * Updating the billing status in userlist. * Add test for the changes to billing lock function * Integration with user actions. * Lint and test fixes * Moved the action struct to a dto. * Updated the version of upload artifact * Updated the download-artifact too. * Tag the docker image correctly. * Go mod tidy * Ignorne pem files * chore(deps): bump golang.org/x/image Bumps [golang.org/x/image](https://github.com/golang/image) from 0.0.0-20211028202545-6944b10bf410 to 0.18.0. - [Commits](https://github.com/golang/image/commits/v0.18.0) --- updated-dependencies: - dependency-name: golang.org/x/image dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump json5 Bumps and [json5](https://github.com/json5/json5). These dependencies needed to be updated together. Updates `json5` from 2.2.1 to 2.2.3 - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) Updates `json5` from 1.0.1 to 2.2.3 - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * refactor: Update Contributing doc * refactor: Update broken link in Makefile * feature: add ability to copy comment link * fix(migration): Looks for pending migrations * refactor: Rewrite versions string * refactor: Get pending versions using slices * refactor: Copy versions slice to local variable * fix: Use pq.Array as SQL query param * fix: Close connection using defer statement * fix: Handle errors during version scan * test: Ensure migration will be executed even with past timestamp * lint: Fix typo in sql request in tests * test: Check error while fetching versions * lint: Light refactor * feat: Copy versions array to local var Co-authored-by: Matt Roberts <roberts.mattroberts@gmail.com> * Fixes getfider#1156 * Fix: No webhook message when post deleted with no comment. * Fixed tests, added one for no-comment-delete of post. * First set of proposed UI tweaks. * Fixing tests * Added missing description * Fixed tests for google font * Settings tweaks * My settings UI tweaks * More webhooks tweaks * No duplicate emails on the "show votes" * Fixed lint issue * WIP notifications modal. * Remove the paddle webhooks from CSRF checks. * Revert "Merge pull request getfider#1203 from Quentinchampenois/fix/pending_migrations" This reverts commit 42c9a98, reversing changes made to a9c05c5. * Fix: Can't access tenant from context in paddle webhook logic (but don't need to anyway) * Billing status should be forced to string * No need to log this * Changing to use matrix strategy for parallel builds * Notifications dropdown * Username component shouldn't show email unless explicitly requested * Formatting. * Revert "Changing to use matrix strategy for parallel builds" This reverts commit 55dfbc9. * Missing route * Margin bottom fixes * Some minor changes to the styles * Localised notifications modal * Locale files updated * Moved the userlist logic so it runs for social signups too. * Fixed previous userlist change. * Changed the email details for welcome emails. * No notifications improvements. * Console.logs removed * Formatting * More notification spacing tweaks * More styling, plus "mark all as read" * Borders in the notifications modal * Show posts mobile view. * Small tweaks to the powered by link * Changed how google fonts are included. * Order notifications by date desc * Messing about with reactions * Working reactions UI and backend * Lint checks * Viewing reactions for anonymous users * Sort the reactions by count * Make comments stand out more Techincally this is part of the UI stuff, but it stands out when you have the reactions in there so adding it here. * More tests * Validate that the reaction is one of the allowed emoji responses. * Update Dockerfile to Debian Bookworm and NodeJS 22 * Update gomarkdown/markdown dependency * Changed some bits on the main readme. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Matthew Yarmolinsky <yarmolinskymatthew@gmail.com> Co-authored-by: goenning <me@goenning.net> Co-authored-by: Ik <113038466+Ik1497@users.noreply.github.com> Co-authored-by: Matt Roberts <roberts.mattroberts@gmail.com> Co-authored-by: mway-niels <53857383+mway-niels@users.noreply.github.com> Co-authored-by: Brian Pham <nguyenphamswork@gmail.com> Co-authored-by: Dinh Nguyen Pham <63203684+npham49@users.noreply.github.com> Co-authored-by: Maher El Gamil <maherelgamil@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com> Co-authored-by: indyteo <theo.mail@laposte.net> Co-authored-by: Kim Tiago Baptista <kimtiago@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: All scrollbars would always be visible in the
VotesModal
component. See #1133