Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Add a few tests, including for Loader #433

Merged
merged 5 commits into from
Sep 22, 2019
Merged

Add a few tests, including for Loader #433

merged 5 commits into from
Sep 22, 2019

Conversation

kienstra
Copy link
Collaborator

  • This adds tests for random parts of the plugin, including Loader and some of the new repeater helper functions
  • Unit tests for the repeater functions probably wouldn't help, as they're mainly wrappers for other logic

Testing these in an integration test
is probably the most useful,
as they're mainly wrappers for other logic.
Also, remove an isset() check
as empty() will handle that case.
To indicate that the helpers.php functions
are covered, like block_rows() and block_row().
Still, I need to add a lot of tests for this class,
and a few others.
This is passing it a row number,
so it should not use %s.
@kienstra
Copy link
Collaborator Author

Request For Review

Hi @lukecarbis,
Could you please review this?

Thanks, Luke! 🎉

@kienstra kienstra requested a review from lukecarbis September 19, 2019 06:37
Copy link
Member

@lukecarbis lukecarbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kienstra
Copy link
Collaborator Author

Thanks, Luke!

@kienstra kienstra merged commit 4d0956a into develop Sep 22, 2019
@kienstra kienstra deleted the add/testing branch September 22, 2019 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants