This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
A bunch of small optimisations #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`with_multiplicities` bool cannot have 3 states; `None` was evaluated to false
internally anyway.
We can directly create Amount from f64
klochowicz
force-pushed
the
small-fixes
branch
from
f69ae33 to
9332582
Compare
bonomat
reviewed
Oct 14, 2022
| @@ -240,8 +239,7 @@ impl Div<Price> for Contracts { | |||
| fn div(self, rhs: Price) -> Self::Output { | |||
| let mut btc = self.0 / rhs.0; | |||
| btc.rescale(8); | |||
| Amount::from_str_in(&btc.to_string(), Denomination::Bitcoin) | |||
| .expect("Error computing BTC amount") | |||
| Amount::from_btc(btc.to_f64().expect("to fit in f64")).expect("Parse the BTC amount") | |||
There was a problem hiding this comment.
This does the same thing underthehood.
There was a problem hiding this comment.
not quite - we avoid using Decimals Display implementation, which is AFAICT not as straightforward as f64 (regular float).
There was a problem hiding this comment.
but good point that Amount::from_btc creates a String. I have overlooked that.
bonomat
approved these changes
Oct 14, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit details.