Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch S3 403s again in addition to 404s #131

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

CloudNiner
Copy link
Contributor

@CloudNiner CloudNiner commented Dec 18, 2019

These 403s don't have a specific subclass,
so we catch the error that was thrown when
this code was run:

software.amazon.awssdk.services.s3.model.S3Exception:
Access Denied (Service: S3, Status Code: 403, Request ID: _)

Fallout from GT3.1 upgrade, we should have caught this exception
in #129 as well to properly refactor from VP 1.0 days.

Demo

No 404/403 errors from process run locally:
Screen Shot 2019-12-18 at 11 23 50 AM
Screen Shot 2019-12-18 at 11 24 04 AM

@CloudNiner CloudNiner requested a review from jpolchlo December 18, 2019 14:51
@CloudNiner CloudNiner force-pushed the fixup/awf/another-aws-error branch 2 times, most recently from e4011fc to 60b257b Compare December 18, 2019 14:53
These 403s don't have a specific subclass,
so we catch the error that was thrown when
this code was run:

software.amazon.awssdk.services.s3.model.S3Exception:
  Access Denied (Service: S3, Status Code: 403, Request ID: _)
@CloudNiner CloudNiner force-pushed the fixup/awf/another-aws-error branch from 60b257b to 2a4a084 Compare December 18, 2019 16:11
Copy link
Contributor

@jpolchlo jpolchlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CloudNiner CloudNiner merged commit 9ef6f84 into master Dec 18, 2019
@CloudNiner CloudNiner deleted the fixup/awf/another-aws-error branch December 18, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants