MosaicRasterSource improvements #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
feature/effectful-mosaic-rs
branch
2 times, most recently
from
6bc0a94 to
b92fd30
Compare
pomadchin
changed the title
pomadchin
force-pushed
the
feature/effectful-mosaic-rs
branch
from
4295411 to
2975193
Compare
pomadchin
force-pushed
the
feature/effectful-mosaic-rs
branch
from
2975193 to
f86269a
Compare
pomadchin
force-pushed
the
feature/effectful-mosaic-rs
branch
from
f86269a to
13aaff4
Compare
pomadchin
force-pushed
the
feature/effectful-mosaic-rs
branch
from
19fad71 to
0debaec
Compare
pomadchin
changed the title
pomadchin
force-pushed
the
feature/effectful-mosaic-rs
branch
2 times, most recently
from
853b324 to
1e8b0d7
Compare
pomadchin
force-pushed
the
feature/effectful-mosaic-rs
branch
from
1e8b0d7 to
182b92a
Compare
pomadchin
commented
Apr 28, 2021
| * whether they'll have the same CRS. crs allows specifying the CRS on read instead of | ||
| * having to make sure at compile time that you're threading CRSes through everywhere correctly. | ||
| */ | ||
| abstract class MosaicRasterSourceF[F[_]: Monad: Parallel] extends RasterSourceF[F] { |
There was a problem hiding this comment.
Sadly, none of these interfaces were integrated into gt server :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds effectful RasterSources concept into the repo as well as two MosaicRasterSources: one that works only with effectful RasterSources, another one is able to lift RasterSource into the context.
This PR resolves #344 but does not address the general issue that RasterSources as synchrnous interfaces. It contains some attempts and backports from the geotrellis-contrib repo, but it became obvious that it would require much more time to accomplish them.
Checklist
Closes #344