Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StacRasterSources improvements #345

Merged
merged 10 commits into from
Mar 23, 2021
Merged

StacRasterSources improvements #345

merged 10 commits into from
Mar 23, 2021

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Mar 18, 2021 •
edited
Loading

Overview

Checklist

  • Description of PR is in an appropriate section of the CHANGELOG and grouped with similar changes if possible

Closes #340
Closes #326

@pomadchin pomadchin marked this pull request as ready for review March 20, 2021 01:36
@pomadchin pomadchin requested a review from jisantuc March 20, 2021 01:36
@pomadchin pomadchin force-pushed the feature/stac-rastersources branch from c3bc732 to 864ff1f Compare March 20, 2021 01:41
jisantuc
jisantuc suggested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@jisantuc jisantuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy lots of questions, sorry

ogc/src/main/scala/geotrellis/server/ogc/OgcTime.scala Outdated Show resolved Hide resolved
ogc/src/main/scala/geotrellis/server/ogc/wms/WmsModel.scala Show resolved Hide resolved
stac-example/catalog/landsat-stac-layers/catalog.json Show resolved Hide resolved
stac-example/catalog/landsat-stac-layers/landsat-8-l1/catalog.json Show resolved Hide resolved
stac-example/catalog/landsat-stac-layers/layers/catalog.json Show resolved Hide resolved
stac-example/src/main/scala/geotrellis/stac/raster/StacAsset.scala Show resolved Hide resolved
stac-example/src/main/scala/geotrellis/stac/raster/StacAssetRasterSource.scala Show resolved Hide resolved
stac-example/src/main/scala/geotrellis/stac/raster/StacAssetReprojectRasterSource.scala Show resolved Hide resolved
stac-example/src/main/scala/geotrellis/stac/raster/StacCollectionSource.scala Show resolved Hide resolved
stac-example/src/main/scala/geotrellis/stac/raster/StacItemOps.scala Outdated Show resolved Hide resolved
@pomadchin pomadchin force-pushed the feature/stac-rastersources branch from 14a3b09 to 85455da Compare March 22, 2021 23:04
@pomadchin pomadchin force-pushed the feature/stac-rastersources branch from 85455da to bb05bbc Compare March 22, 2021 23:23
@pomadchin pomadchin requested a review from jisantuc March 22, 2021 23:24
@pomadchin
Copy link
Member Author

pomadchin commented Mar 22, 2021 •
edited
Loading

@jisantuc ): sry I bumped the scalafmt version up and that led to unpredictable results...

ac06e9f reverts scalafmt version

@pomadchin pomadchin force-pushed the feature/stac-rastersources branch 2 times, most recently from e9208e0 to 92bbd77 Compare March 23, 2021 01:04
@pomadchin pomadchin force-pushed the feature/stac-rastersources branch 3 times, most recently from 3f4412f to afeacc9 Compare March 23, 2021 18:32
@pomadchin pomadchin force-pushed the feature/stac-rastersources branch from afeacc9 to 2b26f96 Compare March 23, 2021 18:33
jisantuc
jisantuc approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@jisantuc jisantuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Maybe a bad question, but would it make sense to move gt-server ogc out into its own project to make CI faster?

@pomadchin
Copy link
Member Author

@jisantuc eh yea, well it kind of makes sense to move it out of this repo, but from the other hand it is only used by projects within this repo o: 8 minutes is not that bad :D

@pomadchin pomadchin merged commit d0a754a into develop Mar 23, 2021
@pomadchin pomadchin deleted the feature/stac-rastersources branch March 23, 2021 19:16
@pomadchin pomadchin mentioned this pull request Mar 24, 2021
Closed
@pomadchin pomadchin mentioned this pull request Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jisantuc jisantuc jisantuc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StacCollectionRasterSource implementation StacAssetRasterSource improvements
2 participants
@pomadchin @jisantuc