Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configurable CRS in WCS services #314

Merged
merged 5 commits into from
Feb 21, 2021
Merged

Support configurable CRS in WCS services #314

merged 5 commits into from
Feb 21, 2021

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Feb 16, 2021 •
edited
Loading

Overview

This PR adds a supportedProjections attribute to the WcsConf case class, adds example configuration to the stac-example and ogc-example projects, and consumes those supported projections when rendering the GetCapabilities response.

Checklist

  • Description of PR is in an appropriate section of the CHANGELOG and grouped with similar changes if possible

Demo

$ http :9000 service==wcs request==getcapabilities
HTTP/1.1 200 OK
Content-Length: 8925
Content-Type: application/xml
Date: Tue, 16 Feb 2021 16:46:01 GMT

...
<CoverageSummary>
  <ows:Title>US NED</ows:Title>
  <ows:WGS84BoundingBox>
    <ows:LowerCorner>-15.015761449275047 -171.00056648254395</ows:LowerCorner>
    <ows:UpperCorner>72.00056298703436 164.00399450196636</ows:UpperCorner>
  </ows:WGS84BoundingBox>
  <SupportedCRS>urn:ogc:def:crs:OGC::imageCRS</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3785</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::4326</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3410</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3978</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::4617</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3979</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::3413</SupportedCRS>
  <SupportedCRS>urn:ogc:def:crs:EPSG::26916</SupportedCRS>
  <SupportedFormat>image/geotiff</SupportedFormat>
  <SupportedFormat>image/jpeg</SupportedFormat>
  <SupportedFormat>image/png</SupportedFormat>
  <Identifier>us-ned</Identifier>
</CoverageSummary>
...

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • make the demo request with the ogc-example project running
  • confirm you also see the CRSes that match the values from the application.conf
  • optional: change those values and verify the server respects your changes

Closes #305

@jisantuc jisantuc requested a review from pomadchin February 16, 2021 16:49
pomadchin
pomadchin requested changes Feb 17, 2021
View reviewed changes
Copy link
Member

@pomadchin pomadchin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Could you also push these changes into the WCS DescribeCoverage request?

The request example: http://localhost:9000/?service=WCS&request=DescribeCoverage&identifiers=us-ned

@jisantuc jisantuc force-pushed the feature/js/support-configurable-crs-for-wcs branch from b5d1bac to d4e2829 Compare February 17, 2021 19:24
@jisantuc
Copy link
Contributor Author

d4e2829 does the DescribeCoverage change -- it wasn't clear to me that the bboxes needed to include all the CRSes as well, since the wms getCapabilities response doesn't include it and the methods for bbox reprojection don't seem to be called anywhere (bboxIn on the two OGCSources I mean). Let me know if that read is incorrect.

@pomadchin
Copy link
Member

@jisantuc I think the main goal of the GetDescribeCoverage to make the service comaptible with tools like QGIS. I think QGIS is pretty happy without having all projections listed in the GetCoverage, but (accroding to specs) we still need to list all projections supported by the coverage.

pomadchin
pomadchin approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pomadchin pomadchin force-pushed the feature/js/support-configurable-crs-for-wcs branch from 2e81a0f to 2d286e9 Compare February 21, 2021 14:55
@pomadchin pomadchin merged commit f4bd4f6 into develop Feb 21, 2021
@pomadchin pomadchin deleted the feature/js/support-configurable-crs-for-wcs branch February 21, 2021 14:57
@pomadchin pomadchin mentioned this pull request Apr 22, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomadchin pomadchin pomadchin approved these changes

Assignees

@pomadchin pomadchin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable a configuration of supported projections for WCS
2 participants
@jisantuc @pomadchin