[GEOT-6503] Extend SLD to support background fill specification at the UserStyle level #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodygarnett
reviewed
Jan 27, 2020
|
|
||
| /** The background Fill , if any, <code>null</code> otherwise */ | ||
| public default Fill getBackground() { | ||
| return null; |
jodygarnett
reviewed
Jan 27, 2020
| if (firstStyle.getBackground() != null) { | ||
| Paint background = styleFactory.getPaint(firstStyle.getBackground(), null, null); | ||
| graphics.setPaint(background); | ||
| graphics.fill(paintArea); |
There was a problem hiding this comment.
Do we need to make the image transparent, before applying your fill, in case the fill has some transparency effects?
There was a problem hiding this comment.
No, StreamingRenderer is given a Graphic2D, it should not alter what was done before on it (could have been used for overlay on top of other stuff for example). It should be simple and predictable, just do what it was asked to do (apply the background).
ianturton
approved these changes
Jan 28, 2020
aaime
force-pushed
the
sld_background
branch
3 times, most recently
from
a4409d9 to
8daa5d3
Compare
|
@ianturton @jodygarnett docs and tests completed, ready for actual review. |
aaime
changed the title
…e UserStyle level
15 tasks
dromagnoli
approved these changes
Feb 3, 2020
| StyledLayerDescriptor sld, | ||
| BackgroundMBLayer background, | ||
| FilterFactory2 ff) { | ||
| // Background does not use a source; construct a user later with a world extent |
There was a problem hiding this comment.
just a minor TYPO here... layer instead of later
jodygarnett
requested changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLD background support with MBStyle leveraging it to get simpler, more reliable background layer.
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for unsupported modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.