Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSIP-184] Promote MBStyle to extension #4098

Merged
merged 8 commits into from
Mar 3, 2020

Conversation

jodygarnett
Copy link
Member

@jodygarnett jodygarnett commented Mar 2, 2020

The Vector Tile extension for GeoServer is a popular way to generate tiles for use in MapBox.GL or OpenLayers.

The MBStyle extension is a great addition to this workflow, enabling the same styling for both client side and server side.

See also:

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for community modules):

  • There is a ticket in Jira describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • Commit message must be in the form "[GEOS-XYZW] Title of the Jira ticket" (using GSIP here)
  • The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it.
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks (QA checks results will be reported by travis-ci after opening this PR)
  • Commits changing the UI, existing user workflows, or adding new functionality, need to include documentation updates (screenshots, text)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
@jodygarnett jodygarnett requested a review from tbarsballe March 2, 2020 18:22
@aaime
Copy link
Member

aaime commented Mar 2, 2020

Did you try an assembly? Does the zip contain the jars you'd expect?
I think you need to make src/release/pom.xml depend on the mbstyle module for that to happen, but I don't see that file modified (basically what you removed from the src/community/release/pom.xml should go into src/release/pom.xml).

@jodygarnett
Copy link
Member Author

Did you try an assembly? Does the zip contain the jars you'd expect?

Let me test that, right now I am making the jira tickets.

I think you need to make src/release/pom.xml depend on the mbstyle module for that to happen, but I don't see that file modified (basically what you removed from the src/community/release/pom.xml should go into src/release/pom.xml).

I did a search and replace in the the codebase, but may of missed something :)

Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Copy link
Member

@tbarsballe tbarsballe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that one test you're currently working on, everything else looks good to me - Andrea already caught the release config updates, which I see you've added - looks correct to me.

@simboss simboss changed the title [GSIP-174] Promote MBStyle to extension [GSIP-184] Promote MBStyle to extension Mar 2, 2020
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
@jodygarnett
Copy link
Member Author

Thanks everyone for the review, I believe I have accounted for all the feedback.

@jodygarnett jodygarnett merged commit b3c4a94 into geoserver:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants