-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSIP-184] Promote MBStyle to extension #4098
Conversation
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
...extension/mbstyle/src/test/java/org/geoserver/community/mbstyle/web/MBStyleEditPageTest.java
Outdated
Show resolved
Hide resolved
Did you try an assembly? Does the zip contain the jars you'd expect? |
Let me test that, right now I am making the jira tickets.
I did a search and replace in the the codebase, but may of missed something :) |
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that one test you're currently working on, everything else looks good to me - Andrea already caught the release config updates, which I see you've added - looks correct to me.
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
Thanks everyone for the review, I believe I have accounted for all the feedback. |
The Vector Tile extension for GeoServer is a popular way to generate tiles for use in MapBox.GL or OpenLayers.
The MBStyle extension is a great addition to this workflow, enabling the same styling for both client side and server side.
See also:
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for community modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.