Iterate over points using windows instead of zip #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,8 +25,8 @@ fn get_linestring_area<T>(linestring: &LineString<T>) -> T where T: Float { | |||
| return T::zero(); | |||
| } | |||
| let mut tmp = T::zero(); | |||
| for (p1, p2) in linestring.0.iter().zip(linestring.0[1..].iter()) { | |||
| tmp = tmp + (p1.x() * p2.y() - p2.x() * p1.y()); | |||
| for ps in linestring.0.windows(2).into_iter() { | |||
There was a problem hiding this comment.
FYI, you should be able to just do for ps in linestring.0.windows(2) here. Using a for loop will automatically call IntoIterator for the item being interated over
https://doc.rust-lang.org/std/iter/index.html#for-loops-and-intoiterator
|
Thanks! It's great that simplifying the logic here results in better performance |
nyurik
pushed a commit
to nyurik/geo
that referenced
this pull request
Mar 19, 2022
67: Minimal support for JTS extensions r=michaelkirk a=rmanoka Refer discussion in georust#50 + support LINEARRING by parsing it as a LINESTRING + test LINEARRING parsing - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Co-authored-by: Rajsekar Manokaran <rajsekar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use windows instead of zip to iterate over points. It seems also slightly faster from my bench.