Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COORD_PRECISION is now f32 #40

Merged
merged 1 commit into from
Jul 17, 2016
Merged

COORD_PRECISION is now f32 #40

merged 1 commit into from
Jul 17, 2016

Conversation

Kerollmops
Copy link
Contributor

@Kerollmops Kerollmops commented Jul 17, 2016 •
edited
Loading

#39

@Kerollmops Kerollmops self-assigned this Jul 17, 2016
@Kerollmops Kerollmops merged commit 8369162 into master Jul 17, 2016
@frewsxcv frewsxcv deleted the coord_precision_f32 branch July 17, 2016 13:02
@frewsxcv frewsxcv mentioned this pull request Jul 17, 2016
Closed
@frewsxcv
Copy link
Member

Version 0.2.0 of geo-rust has been released which includes these changes.

nyurik pushed a commit to nyurik/geo that referenced this pull request Mar 19, 2022
@bors @osialr
Merge georust#40
934cb62 
40: Remove recursion to prevent stack overflow r=frewsxcv a=osialr

Was running AFL on this library and found that large but bad inputs could cause stack overflows.  Switched the Tokenizer's `read_until_whitespace` and `next` to use a non-recursive implementation.  

This has the side effect of improving performance.  On my Ubuntu VM, `cargo bench` runtime reduced by 18% on parse small and 60% on parse big.

Co-authored-by: Ryan Osial <ryan.osial@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kerollmops Kerollmops

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerollmops @frewsxcv