Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First draft for algorithms implementation #24

Merged
merged 1 commit into from
May 13, 2016
Merged

First draft for algorithms implementation #24

merged 1 commit into from
May 13, 2016

Conversation

azime
Copy link
Contributor

@azime azime commented May 12, 2016

Linked to #9

This is a proposition of geometry algorithm implementation.

To keep it simple it only implements a basic algorithm, the computation of a centroid.

The trait is implemented for the moment only for LineString and Polygon.

@frewsxcv
Copy link
Member

Just looked through the code and it looks great! Since you mentioned this is a "draft", is this ready to merge or do you have further changes you want to make?

@azime
Copy link
Contributor Author

azime commented May 13, 2016

You can merge if ok for you, I'll make separate PR.

@frewsxcv
Copy link
Member

frewsxcv commented May 13, 2016 •
edited
Loading

Thanks for your contribution!

@frewsxcv frewsxcv merged commit e204f08 into georust:master May 13, 2016
@frewsxcv
Copy link
Member

Version 0.0.7 has been released which includes these changes.

@frewsxcv frewsxcv mentioned this pull request May 14, 2016
Closed
@frewsxcv frewsxcv mentioned this pull request Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azime @frewsxcv