cross_prod method added to Point #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
reviewed
Mar 12, 2018
src/types.rs
Outdated
| @@ -254,6 +254,25 @@ where | |||
| self.x() * point.x() + self.y() * point.y() | |||
| } | |||
|
|
|||
| /// Returns the cross product of 3 points | |||
There was a problem hiding this comment.
can you add another sentence here saying something like:
A positive value implies
self→point_b→point_cis counter-clockwise, negative implies clockwise.
bors bot
added a commit
that referenced
this pull request
Mar 12, 2018
189: cross_prod method added to Point r=frewsxcv a=Jay9596 Solves #133 `Point` struct now implements a cross product fuction `cross_prod` that use previously used inline in 2 different parts of the codebase. - algorithm/extremes.rs - algorithm/convexhull.rs It uses the same implementation the other inline function were using.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #133
Pointstruct now implements a cross product fuctioncross_prodthat use previously used inline in 2 different parts of the codebase.It uses the same implementation the other inline function were using.