Add associated return type for Centroid algorithm trait. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the future, we can remove the |
frewsxcv
commented
Sep 4, 2017
src/algorithm/centroid.rs
Outdated
| @@ -6,6 +6,8 @@ use algorithm::distance::Distance; | |||
|
|
|||
| /// Calculation of the centroid. | |||
| pub trait Centroid<T: Float> { | |||
| type Centroid; | |||
There was a problem hiding this comment.
i originally titled this Result, but that's confusing since there's std::result::Result which is conceptually different
frewsxcv
commented
Sep 4, 2017
src/algorithm/centroid.rs
Outdated
| @@ -6,6 +6,8 @@ use algorithm::distance::Distance; | |||
|
|
|||
| /// Calculation of the centroid. | |||
| pub trait Centroid<T: Float> { | |||
| type Centroid; | |||
There was a problem hiding this comment.
actually, maybe Output would be a better name here. i'm doing the same thing with bounding box right now and it's confusing that the trait is BoundingBox, the associated return type name is BoundingBox and the actual return type is Bbox.
frewsxcv
force-pushed
the
frewsxcv-centroid-type
branch
from
7a55477 to
10330f1
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.