Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic trait impl for RotatePoint. #153

Merged
merged 2 commits into from
Sep 4, 2017
Merged

Add generic trait impl for RotatePoint. #153

merged 2 commits into from
Sep 4, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Sep 4, 2017

Originally added in #151, but
extracted out due to indecision about how to move forward with Rotate.

@frewsxcv
Add generic trait impl for RotatePoint.
5919f15 
Originally added in #151, but
extracted out due to indecision about how to move forward with Rotate.
@frewsxcv frewsxcv requested a review from urschrei September 4, 2017 12:40
@urschrei
Copy link
Member

urschrei commented Sep 4, 2017

I can't think of a good way to unify this, short of splitting the Centroid trait into CentroidWeighted and CentroidUnweighted or similar. I don't think it would cause confusion, but it's certainly less simple than the current approach.

@frewsxcv frewsxcv mentioned this pull request Sep 4, 2017
Closed
@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 4, 2017

@urschrei You're talking about Rotate (not RotatePoint) right? This PR doesn't change the centroid or rotation behavior

@urschrei
Copy link
Member

urschrei commented Sep 4, 2017

@frewsxcv Yep, sorry, should probably just have left it as a comment on #151.

@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 4, 2017

bors r+

bors bot added a commit that referenced this pull request Sep 4, 2017
@bors
Merge #153
b1410a6 
153: Add generic trait impl for RotatePoint. r=frewsxcv a=frewsxcv

Originally added in #151, but
extracted out due to indecision about how to move forward with Rotate.
@bors
Copy link
Contributor

bors bot commented Sep 4, 2017

Build succeeded

@bors bors bot merged commit 7d7c31e into master Sep 4, 2017
@frewsxcv frewsxcv deleted the frewsxcv-generic-rotate-point branch September 4, 2017 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urschrei urschrei urschrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frewsxcv @urschrei